Learning center

The reviewer flags the change your pull request exists to make

When an AI reviewer objects to the behavior your pull request is meant to change, do not revert it. Point the thread to the issue or description that states the intent, then check who depended on the old behavior, because that part of the comment can still be right.

Separate the objection from the consequence#

A reviewer that compares a diff with the code before it will notice when behavior changes. It cannot always tell an intended change from an accidental one, so it reports both. A comment such as "this removes X" or "this reverses Y" usually contains two claims:

  • the behavior changed, which is the point of your pull request and needs no fix;
  • something relied on the old behavior, which may be true and needs a check.

Answer the first with a pointer. Answer the second with evidence: the callers, the tests that encoded the old behavior, or the documentation that defines the contract.

A reversal the description already explained#

In November 2026, a Home Assistant core pull request changed what happens when an integration's after_dependencies fail to set up. Its description gave the history: "Since #141593 ("Always set up after dependencies if they are scheduled to be loaded") a failed after dependency fails the integration that lists it." It stated the goal: "This PR restores the pre-#141593 semantics while keeping the fix of #141593". Pull request

Copilot's last review flagged exactly that: "The change reverses #141593's bootstrap failure-propagation behavior across integrations, so a core maintainer should confirm the intended after-dependency contract." Copilot's review

The claim is accurate and the change is intended. The developer documentation defines after_dependencies as "dependencies that might be used by the integration but aren't essential," and gives an example: if stream is not configured, "camera will still load." Integration manifest: after dependencies Failing an integration because a non-essential dependency failed contradicts that contract, which is what the pull request restored.

Nobody replied to the comment. A maintainer approved and merged the pull request on 9 November 2026, which is the confirmation Copilot asked for. The description was the record of intent, and it did that job, although a one-line reply in the review linking it would have left the comment visibly answered.

The same pull request shows the other kind of comment. An earlier Copilot finding, rated high severity, concerned "A dependency listed in both dependencies and after_dependencies". Review comment That one was about a case the intended change could get wrong, and the merged test covers it with a parameter named dependency_and_after_dependency that expects setup to fail. Pull request diff One comment on the intended change needed a pointer. The comment on its edge needed a test.

A removal whose description was wrong#

A Home Assistant pull request merged in November 2026 removed two extra warnings that the device registry logged for a deprecated via_device argument. One of its titles called them "unreachable". Copilot asked the author to "acknowledge the removal of warnings reachable by custom integrations rather than characterize it as unreachable-code cleanup." Copilot's review

The author agreed with the fact and kept the change:

Right, since #189595 these warnings are logged for custom integrations next to the via_device deprecation. We still want to remove them to avoid the double logging: via_device is deprecated, so the deprecation warning already tells custom integrations to move to via_device_id. The PR title and description are updated to describe this as an intentional removal.

Author's reply

The pull request was retitled from "unreachable" to "redundant". A maintainer approved it: "there's no reason to both complain about using deprecated via_device, and then complain about how the via_device is incorrect." Approval It merged on 3 November 2026.

Here the reviewer was wrong that the removal needed undoing and right that the stated intent was inaccurate. Custom integrations could still reach the removed warnings, so the description had to say what they would lose, and what still warned them. The fix was to the record, not to the code.

Check who relied on the old behavior#

Before you answer with a pointer, look for anything that encoded the behavior you are changing:

  1. Tests. If your change edits an existing assertion about the old behavior, the reviewer has found a real contract, and the description should say why it changes. The after-dependency pull request edits no existing test and adds one.
  2. Callers. Search for code that relies on the old result. For the after-dependency change, that would be an integration that lists a dependency only in after_dependencies but calls it as if it were loaded. We did not search Home Assistant's integrations for one.
  3. External users. For a public API, configuration or log output, decide what they lose and say it in the description, as the device registry pull request did once Copilot pushed.
What you findDecisionWhat to write
The change is stated in the issue or description, and nothing relied on the old behaviorDismissA link to the description or issue
The description is missing or inaccurate about the changeFix the description, keep the codeWhat changed and who is affected
A test or caller depends on the old behaviorChange the caller or the test, or narrow the changeThe commit, and why the old contract no longer holds
The comment is about an edge of the change, not the change itselfTreat it as an ordinary findingA test or a fix

The first row is where a dismissal reply applies. If the behavior change is real and wanted but some old caller cannot move in this pull request, the guide to comments on unchanged code covers deferring it with an issue that someone owns.

One month of free code review.

New organizations get one calendar month of hosted code review for private and public GitHub repositories. No card or cloud connection required. Eligibility and fair-use terms.

Start free with GitHub

Related reading