Read the Kian re-check on an automatic fix pull request

Open the fix pull request from the confirmation and compare the Kian re-check with the current fix commit. The result describes the obligation checked against the recorded evidence.

Interpret the result on the fix commit#

The Kian re-check is a fix pull request's only check: Proofline does not review pull requests it opened, and Reviews → Pull requests says so for them. The confirmation's Automatic fix line on Latent risks shows the result for the newest recorded commit. For the full result, find Kian re-check in the pull request body on GitHub. When the line says Proofline could not post this result to the pull request, the body has no section for that result. Select Kian re-check on the line to read it in the investigation instead, which shows the commit the re-check judged, the reason for an incomplete result, the grants it read from the commit and the Kian records it cites. The section names the commit it checked, the confirmed problem and the result. Compare that commit with the pull request's current head before relying on the result. A new head starts a new re-check, and so does a rerun at the same head; earlier results remain recorded.

The section's first line gives its conclusion. The Automatic fix line and the environment's investigations show the same conclusion in their own words:

  • Kian re-check: no counterexample, shown as No counterexample in the console: Kian found no counterexample to the obligation the section names in complete, fresh infrastructure evidence, with the grants the fix commit declares. This never means the fix is safe or that other problems are absent.
  • Kian re-check: the problem remains, shown as Counterexample: Kian still finds that obligation violated with the fix's declared grants. Read the explanation to see what remains wrong.
  • Kian re-check: incomplete, shown as Incomplete: the re-check could not decide. The section gives the reason and its detail; the fix remains unchecked.

Proofline marks an automatic fix pull request ready for review only when a qualified Kian re-check of its current head finds No counterexample and the rule that opened it is still the organization's rule. Every other result promotes nothing: a draft stays a draft, and a pull request that is already ready for review stays ready. When Proofline could post the result, the pull request body gives the reason and, for a pull request already ready, says that Proofline did not mark that commit ready. Turning the rule off or saving any change to it prevents promotion even when the re-check finds no counterexample. Proofline never merges the pull request.

Search help

Tab to a result. Enter to open. Escape to close.