Trace a GitHub finding thread after a later push

Reopen Proofline's original finding thread on GitHub after pushing a change. Its reply explains what the later review could establish at the new commit.

Read the replies after a later push#

When you push again, the new review checks the earlier findings that the push could affect. Proofline reports the result on the finding's newest thread:

  • Fixed. Proofline adds a line to the thread's first comment saying Proofline confirmed this finding was fixed, with a link to the review, and resolves the thread. It posts no reply. GitHub lets Proofline resolve a thread only when your installation of the Proofline GitHub App has granted Contents: write. Without that permission, the line also says that Proofline could not resolve the thread, and the thread stays open for you to resolve. Proofline does not count it as an unresolved thread.
  • Still present. Proofline replies Still present in this version, and says whether the finding's checks still fail or Proofline found the issue again.
  • Returned. When the thread last showed the finding as fixed and the issue is back, the reply reads Returned in this version instead.

If someone marked a code finding fixed on the pull request, for example by replying fixed on its thread, and a later review finds the issue again, Proofline replies Still present at that commit, with where the issue is now if it moved, and reopens the thread if it was resolved.

Proofline posts nothing on a thread when:

  • the new review opened a new thread for the same finding, which states the finding at the new commit;
  • Proofline could not tell whether the fix worked. The finding stays open, and the finding page in Proofline lists the attempt and its reason;
  • the finding cites only files the pull request no longer changes;
  • the finding has no thread on the diff, or GitHub no longer accepts replies on its thread.

Search help

Tab to a result. Enter to open. Escape to close.